feat: add quick select list options #99
Conversation
amliu-jumptrading
requested review from
asuzuki-jumptrading and
atsai-jumptrading
amliu-jumptrading
force-pushed
the
amliu/quicksearch
branch
4 times, most recently
from
c1ee50c to
784a87e
Compare
src/features/SlotDetails/index.tsx
Outdated
|
|
||
| return ( | ||
| <Flex direction="column" flexGrow="1" flexShrink="1" height="100%"> | ||
| <Flex direction="column" height="100%"> |
There was a problem hiding this comment.
doesn't need to be flex, can just be a div or Box with height: 100%
There was a problem hiding this comment.
I'm using flex here to center the slot search vertically on the page. I can take off the direction since it isn't being used though.
|
|
||
| return ( | ||
| <Flex direction="column" gap="2" flexGrow="1" flexShrink="1"> | ||
| <Flex direction="column" gap="2" width="100%"> |
There was a problem hiding this comment.
seems to be fine without this width 100% too?
There was a problem hiding this comment.
Without the width 100%, the slot content doesn't fill the whole outlet for wider screens
|
|
||
| return ( | ||
| <Grid | ||
| width="100%" |
There was a problem hiding this comment.
Without width 100%, the grid will just use the maxWidth and not wrap when the container becomes too narrow to fully fit the columns
| useEffect(() => { | ||
| if (selectedSlot === undefined) setSearchSlot(""); | ||
| else setSearchSlot(String(selectedSlot)); | ||
| }, [selectedSlot]); |
There was a problem hiding this comment.
useEffect seems unnecessary? Think you can just init searchSlot state from selectedSlot
const [searchSlot, setSearchSlot] = useState(() =>
selectedSlot ? String(selectedSlot) : "",
);
There was a problem hiding this comment.
Going to use selectedSlot === undefined ? "" : String(selectedSlot) since technically selectedSlot can be 0
amliu-jumptrading
force-pushed
the
amliu/quicksearch
branch
from
784a87e to
13466fc
Compare
No description provided.